Conversation
azure-sdk
added
EngSys
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR synchronizes the eng/common directory with azure-sdk-tools, consolidating package validation logic by folding Validate-Package.ps1 functionality directly into Validate-All-Packages.ps1 and converting Update-DevOps-Release-WorkItem.ps1 into a reusable function. This refactoring reduces script call overhead and improves efficiency by performing authentication and DevOps access checks once for all packages rather than per-artifact.
Key changes:
- Consolidated package validation logic into
Validate-All-Packages.ps1with new helper functions - Converted
Update-DevOps-Release-WorkItem.ps1to a function inDevOps-WorkItem-Helpers.ps1 - Added support for direct
PackageInfoFilesparameter as an alternative toArtifactList
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| eng/common/scripts/Validate-All-Packages.ps1 | Consolidated validation logic with new helper functions and added PackageInfoFiles parameter support |
| eng/common/scripts/Prepare-Release.ps1 | Updated to call Update-DevOpsReleaseWorkItem function instead of external script |
| eng/common/scripts/Helpers/DevOps-WorkItem-Helpers.ps1 | Added authentication helper functions and converted Update-DevOps-Release-WorkItem script to function |
| eng/common/pipelines/templates/steps/validate-all-packages.yml | Added PackageInfoFiles parameter with proper typing |
azure-sdk
force-pushed
the
sync-eng/common-users/raych1/update-validat-pkg-template-12478
branch
6 times, most recently
from
1af29f8 to
40ad36e
Compare
raych1
approved these changes
Oct 16, 2025
azure-sdk
force-pushed
the
sync-eng/common-users/raych1/update-validat-pkg-template-12478
branch
from
40ad36e to
589b021
Compare
raych1
approved these changes
Oct 17, 2025
azure-sdk
force-pushed
the
sync-eng/common-users/raych1/update-validat-pkg-template-12478
branch
from
589b021 to
acce4b3
Compare
raych1
approved these changes
Oct 17, 2025
azure-sdk
deleted the
sync-eng/common-users/raych1/update-validat-pkg-template-12478
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#12478 See eng/common workflow